[Libreoffice] [REVIEW] cherry-pick to 3-4: fix fdo#40590 defined names not resolved during file load

[Eike Rathke]

Hi Kohei,

On Tuesday, 2011-09-13 11:50:03 -0400, Kohei Yoshida wrote:

> Actually, I would feel comfortable not cherry-picking these changes, but
> wait until 3.5.  There are quite a number of existing hacks in this area
> that are specially tailored for importing formula expressions, and they
> make it a bit harder for me to decide whether this change won't
> introduce issues in some weird corners.  Sorry about this.

Ok, that's what reviews and sign-offs are for ;)

The only "weird corners" that come to my mind are places where

a) AddString() would be abused similarly to the cases I changed.
   I thoroughly inspected every use of AddString() in the code but
   didn't find any other, both in master and 3-4.

b) lcl_ScDocFunc_CreateTokenArrayXML() is used in a context it's not
   supposed to be used. I _think_ this doesn't happen, as the only
   places using it are ScDocFunc::InterpretEnglishString() and
   ScDocFunc::EnterMatrix(), both if pDoc->IsImportingXML()==true


  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110913/3705119c/attachment.pgp>