[Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code

Eike Rathke ooo at erack.de
Tue Sep 13 12:36:25 PDT 2011


Hi Pierre-André,

On Tuesday, 2011-09-13 19:52:23 +0200, Pierre-André Jacquod wrote:

> The fact to change to class and use boost::noncopyable is an
> improvement not related to this point I guess,

Yes.

> since before the copy-ctor and copy assignment would have worked with
> the struct.

Well, it would had worked by accident.. and not done the right thing. It
would had copied pServicesSvr and the instance handles and refcount, all
these would had been out of sync if the underlying real data changed.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110913/f00568b2/attachment.pgp>


More information about the LibreOffice mailing list