[Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

Michael Meeks michael.meeks at novell.com
Sat Sep 24 00:57:48 PDT 2011


On Sat, 2011-09-24 at 00:36 +0200, Mathias Bauer wrote:
> Really, the layout is a complete mess, at least from an
> architectural POV. There is no clear relationship and ownership between
> objects. That might work better in a world with garbage collection, but
> in the ugly world of pointers this is the road to hell.

	Hey :-) first - many thanks for your review, and great to see you
here !

	I just did a size-able cleanup of color pieces to use
reference-counting everywhere - fixing a number of rather hideous
tangled lifecycle issues in the process, and I was wondering, would it
make sense to add a ref-count + 'dispose' pattern to these Layout
objects in a big one-shot re-factor ?

	Thanks,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list