[Libreoffice] --enable-werror

[Marc-André Laverdière]

I tried doing that, but it seems that my autogen flags made it so that I
was compiling some module unknown to me that was in 'build warning land'.

Unless we don't have modules living in such countries anymore, I won't
want to enable that option.

I see this flag as an aspirational goal "let us fix all that stuff so
that we can -one day- compile everything that way"

I personally am against anything that makes it harder for a n00b like me
to get something done. The learning curve is not-so-easy so lets not
make it worse.

Just my 2 paisa...

Marc-André Laverdière
Software Security Scientist
Innovation Labs, Tata Consultancy Services
Hyderabad, India

On 09/26/2011 04:10 PM, Michael Meeks wrote:
> 
> On Mon, 2011-09-26 at 12:04 +0200, Stephan Bergmann wrote:
>> You mean, you let 
>> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b24bd7a6ec714c74795cf417e35bd036303f3b9> 
>> "hide a WaE... should be fixed properly when the issue is understood" 
>> through 
> 
> 	Wait - is this the end of the world ? we had a completely benign
> warning on master ! :-) it lasted for a day or two, Norbert patched it
> out and mailed me, and I fixed it 'properly'.
> 
> 	I'm sorry - I'm really not seeing the problem here.
> 
>> just because you think you can live without this helpful 
>> --enable-werror stuff?  Hm.
> 
> 	I use the default compile flags; sometimes that means I break people
> that don't use the default compile flags; c'est la vie - on the other
> hand -a-little- breakage that is easily fixed is an -excellent-
> trade-off for pace of development.
> 
> 	The 'good old' days - where all work had to be done in a branch, and
> then compiled on two platforms before merging is *gone* (and -very- good
> riddance). I'll personally stamp on anything that smells like an attempt
> to pull us back to that world -really- hard :-) JFYI. If brokenness gets
> to master, fine - we fix it ASAP, and hope that people commit features &
> fixes more frequently :-)
> 
> 	I don't view a single transient warning as anything broken.
> 
>>> 	Sure - it'd be ideal; anyhow - help much appreciate on my favorite
>>> warning (of which I have several (tens?) of thousand when compiling):
>>>
>>> In file included
>>> from /data/opt/libreoffice/core/sw/source/core/doc/docfly.cxx:66:0:
>>> /data/opt/libreoffice/core/sw/source/core/inc/UndoAttribute.hxx:209:38:
>>> warning: 'auto_ptr' is deprecated (declared at /usr/include/c
>>> ++/4.5/backward/auto_ptr.h:86)
>>
>> Caolán already addressed that, didn't he?
> 
> 	If by already - you mean on Friday evening :-) after much of the work
> was done - then - perhaps :-) but the reality is that we had a situation
> for several days with master giving tens of thousands of warnings while
> building.
> 
> 	Traditionally Caolan and others building with -Werror have politely
> fixed the warnings they found as they went along, doing a very useful
> code cleaning service which is much appreciated. It is not something
> that is yet possible for everyone IMHO. As when it is, I'd welcome a
> formal proposal to turn -Werror-foo on by default at the TSC.
> 
> 	ATB,
> 
> 		Michael.
>