[PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

Albert Thuswaldner albert.thuswaldner at gmail.com
Thu Apr 5 05:05:12 PDT 2012

Hi Markus and Michael,

On Thu, Apr 5, 2012 at 11:57, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:
> Hey Michael,
> thanks for looking into this.
>> my fix actually tried to do this for one of them, but i've noticed that
>> in table3.cxx there is code that hard-codes sorting related arrays to
>> size 3, which crashes when you add back the code that i've commented
>> out; at that point i thought this really needs a calc developer to look
>> at :)
> Oh how ugly. I hope I finally fixed it correctly. I hope that there
> are not more places that define the max sort size independently from
> the original definition in sortparam.hxx.

Ok, my patch for this obviously fanned out into other parts of the
code which I did not originally have an intention to mess with. So my
idea was to keep those parts as they were as much as possible with
there limit on max sort size and all. Since I didn't know how to test
those properly. The affected parts are the uno, vba interface, and a
database (?) interface, I guess.

There are still parts of the code where max sort is limited to 3, for
instance here:

--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@ -439,25 +437,25 @@ void ScCellShell::ExecuteDB( SfxRequest& rReq )

Please let me know what to do with it and I'll provide a patch.

More information about the LibreOffice mailing list