[PATCH] 2/2 List cleanup in SD

Lubos Lunak l.lunak at suse.cz
Tue Apr 10 03:52:31 PDT 2012

On Sunday 01 of April 2012, Rafael Dominguez wrote:
> More cleanup of deprecated class List, need to be pushed after part1 and in
> order.
> Thanks! Please read carefully

 It seems nobody has handled this yet. I have checked the patches and they 
look good to me, except for one thing that I'd like to clear up before 
committing. The patches do changes like this:

     List*                   GetSelectEntryList( sal_uInt16 nDepth );                                                        
+    void                    GetSelectEntryList (sal_uInt16 nDepth, 
std::vector<rtl::OUString> &rEntries) const;             

 Why is that? Changing the return value to a reference argument makes the API 
worse and it seems like an unnecessary change to me.

 Lubos Lunak
 l.lunak at suse.cz

More information about the LibreOffice mailing list