[PATCH] 2/2 List cleanup in SD

Caolán McNamara caolanm at redhat.com
Wed Apr 11 12:23:36 PDT 2012

On Tue, 2012-04-10 at 12:52 +0200, Lubos Lunak wrote:
>      List*                   GetSelectEntryList( sal_uInt16 nDepth );                                                        
> +    void                    GetSelectEntryList (sal_uInt16 nDepth, 
> std::vector<rtl::OUString> &rEntries) const;             
>  Why is that? Changing the return value to a reference argument makes the API 
> worse and it seems like an unnecessary change to me.

Sorry, missed your earlier review. Yeah, struck me as well, but a quick
attempt to remove all uses of the older one shows that there is a good
bit of work still to do before e.g. removing the older
GetSelectEntryList and making the new one return a vector, so the two
still need to coexist for the moment. Maybe renaming the new
GetSelectEntryList to say, getSelectEntryList, and have it return a
vector, or let Rafael iterate through the rest of the nasty cases and
change over afterwards.


More information about the LibreOffice mailing list