[PATCH] Grouping ScFormulaOptions

Kohei Yoshida kohei.yoshida at gmail.com
Tue Apr 10 09:31:28 PDT 2012

Hi Albert,

On Mon, Apr 9, 2012 at 6:31 PM, Albert Thuswaldner
<albert.thuswaldner at gmail.com> wrote:
> Hi Kohei,
> As said back in February:
> http://lists.freedesktop.org/archives/libreoffice/2012-February/027009.html
> here is a follow-on patch that "groups" the formula options in the
> same fashion as the print options.

Reviewed it, and pushed to master with some minor modifications.

What I modified are:

1) have the assignment operator return a non-const reference of "this"
object instead of const reference.
2) have the equality and non-equality operators of ScFormulaOptions
return bool instead of int.

Regarding 2), I didn't modify the return type of operator== for
ScTpFormulaItem because it was a virtual function.

Another nice work, Albert.  Much appreciated. :-)


More information about the LibreOffice mailing list