[PATCH] Grouping ScFormulaOptions
albert.thuswaldner at gmail.com
Wed Apr 11 16:12:39 PDT 2012
Thanks for pushing the patch. I will try to keep my build tree more up
to date in the future.
On Tue, Apr 10, 2012 at 18:31, Kohei Yoshida <kohei.yoshida at gmail.com> wrote:
> Hi Albert,
> On Mon, Apr 9, 2012 at 6:31 PM, Albert Thuswaldner
> <albert.thuswaldner at gmail.com> wrote:
>> Hi Kohei,
>> As said back in February:
>> here is a follow-on patch that "groups" the formula options in the
>> same fashion as the print options.
> Reviewed it, and pushed to master with some minor modifications.
> What I modified are:
> 1) have the assignment operator return a non-const reference of "this"
> object instead of const reference.
> 2) have the equality and non-equality operators of ScFormulaOptions
> return bool instead of int.
> Regarding 2), I didn't modify the return type of operator== for
> ScTpFormulaItem because it was a virtual function.
I was happily unaware of those things. ;)
> Another nice work, Albert. Much appreciated. :-)
Here is a small follow-up patch that removes some unneeded includes
from tpformula.hxx, which I previously overlooked.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1082 bytes
Desc: not available
More information about the LibreOffice