[PATCH][IN PROGRESS] gbuild conversion: module cpputools

David Ostrovsky d.ostrovsky at idaia.de
Tue Apr 10 16:05:01 PDT 2012

Hi David,

thank you for your comments. Here is another try.
See also my comments bellow. If there still any issues, just let me know 
and I will give it another try ;-)


On 08.04.2012 10:29, David Tardon wrote:
> On Wed, Apr 04, 2012 at 06:33:44AM +0200, David Tardon wrote:
>> On Wed, Apr 04, 2012 at 12:50:47AM +0200, David Ostrovsky wrote:
>>> Hi David,
>>> thank you for your comments. Here is another try.
> Hi,
> I looked at the patch and there are still some problems to correct. I
> could easily do it myself, but I think that you can learn more this way.
> So:
> 1. registercomponent sets APP1RPATH=UREBIN. That means the executable
>     should be registered in UREBIN layer, instead of NONE, in gbuild.
>     (Not knowing that is not your fault--I doubt this is documented
>     anywhere...)
> 2. The executables should not be built for IOS.
> 3. unoexe is actually built on IOS, but as a static library.
done. I don't have mac out there to try.
But I commented MACOSX condition out and tried to built it on my Linux 
Then I saw, that Repository.mk should be updated.
With staticLibrary I'm using

$(eval $(call gb_StaticLibrary_use_api,uno,\
     udkapi \

and not this:
$(eval $(call gb_StaticLibrary_use_internal_comprehensive_api,uno,\
     udkapi \

> 4. regsingleton sets an additional compiler flag for MSC. You can use
>     gb_Executable_add_cxxflags to do that in gbuild land.
actually there are two conditions:
1. without debug
2. with MSC compiler
I hope i cathed the right one, please correct me, if I'm wrong.
> 5. re gb_Executable_add_api: you should use
>     gb_Executable_use_internal_comprehensive_api for these
>     executables/libraries that have NO_OFFUH=TRUE in makefile.mk .
only sp2bv and staticLibrary use the old version.
> Note that Michael pushed a stylistic change (that I really like) to
> gbuild meanwhile, so some functions changed name. You will know which
> ones, because you will get an error when trying to use them :-)
done, this one was obvious.
> If you have any doubt, catch me on IRC.
> D.

More information about the LibreOffice mailing list