[PATCH] fdo#48473 No object information in status bar

Markus Mohrhard markus.mohrhard at googlemail.com
Tue Apr 17 12:55:04 PDT 2012


Hey Regina,


>>> commit 29ac03994484cb65725ec697cb7615a31b117b58 translated some comments.
>>> It
>>> translated a String constant too, but left out one occurrences of that
>>> constant. This patch adds the missing translation.
>>>
>>
>> As explained in Hamburg this is not the right fix for the problem. We
>> should instead don't initialize the string with a value and check at
>> this position if the string is empty.
>
>
> No, that does not work. I have tested it. It results in an empty status bar
> for a single click and a "xxx selected" in case of dragging, where the
> changes should be shown. I think, that is because of the test
> if(!aStr.Len()) in line 1181.
>

In this case we need to find another solution. It is never a good idea
to have two string constants at different places that are related.
Either we move it to a variable and use the variable for that or we
find another clean solution. Thorsten mentioned also that using
nothing is not the best idea because it is a valid name in this case.

Regards,
Markus


More information about the LibreOffice mailing list