[PUSHED-3-5, REVIEW-3-5-3] fdo#48969 ODF import measure conversion regression

Fridrich Strba fridrich.strba at graduateinstitute.ch
Fri Apr 20 13:39:08 PDT 2012

I cherry-picked the commits into 3-5 branch and added


for fixing backporting issues.

We need 2 more reviewers to get all that bunch of 4 patches to 3.5.3.
Would be nice to have this regression fixed asap.


On 20/04/12 22:01, Michael Stahl wrote:
> this is a funny regression in 3.5, the unit parameters to the
> unit conversion function were switched, so it went in the wrong
> direction, resulting in tiny font sizes when opening ODF documents
> produced my MSOffice (they apparently use some obscure "inch" unit that
> needs converting).
> the buggy conversion function sax::Converter::convertDouble was buggy
> since it was added many years ago, but it was also unused, until
> i cleaned up some code duplication and removed its duplicate
> (which did it correctly) with commit
> 3ca2bef76886450058d1667703aeafe4c2e456c3
> proposed fix for libreoffice-3-5:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=84aeb737c7c013c8d98d8c40abfca44f6f70cee8
> for good measure (?) i've implemented various additional conversions as
> well, no idea why they were unimplemented before:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=62a0b2405798a3be6a4e38652f1da7a685c84bfc
> to prevent future calamities of that nature i've added a unit test:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee376102becc16c0c44d23e5eb2a322aadc45197
> also, apologies to Radek who i've suspected to be the culprit but upon
> closer examination he is innocent :)
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

More information about the LibreOffice mailing list