[Libreoffice-commits] .: filter/inc filter/Library_msfilter.mk filter/Package_inc.mk filter/source sw/source writerfilter/Library_rtftok.mk writerfilter/source

[Lubos Lunak]

On Wednesday 25 of April 2012, Miklos Vajna wrote:
>     msfilter::util: avoid code duplication by merging from sw and
> writerfilter
>
...
> +rtl_TextEncoding GetDefaultTextEncoding()
> +{
> +    const rtl::OUString& rLanguage =
> Application::GetSettings().GetLocale().Language; +
> +    if (rLanguage == "cs" || rLanguage == "hu" || rLanguage == "pl")
> +        return RTL_TEXTENCODING_MS_1250;
...
> -            const SvxLanguageItem *pLang =
> -                (const SvxLanguageItem*)GetFmtAttr(RES_CHRATR_LANGUAGE);
> -            if (pLang)
> -            {
> -                switch (pLang->GetLanguage())
> -                {
> -                    case LANGUAGE_CZECH:
> -                    case LANGUAGE_HUNGARIAN:
> -                    case LANGUAGE_POLISH:
> -                        eSrcCharSet = RTL_TEXTENCODING_MS_1250;
> -                        break;

 Are you sure this is right? The old code used SvxLanguageItem, not 
Application::GetSettings().

-- 
 Lubos Lunak
 l.lunak at suse.cz