[PUSHED 3-6 3-5] fdo#50654: update virtual device width on modifying WB_EXTRAFIELD flag

Petr Mladek pmladek at suse.cz
Mon Aug 13 03:29:59 PDT 2012

Ivan Timofeev píše v St 08. 08. 2012 v 22:58 +0400:
> Hi,
> https://bugs.freedesktop.org/show_bug.cgi?id=50654
> "Writer, Ruler: Paint issue at bottom left-ruler"
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=84d5e639b08a1f96b41b7b5b6af51c703b0cd620
> fixes it, the commit message explains all.
> And although it is maybe just a cosmetic issue, it would be great to 
> have the fix in 3-6 (where everyone looks to the rulers now :) and 
> possibly in 3-5(?)

It looks sensible and works => pushed into both branches:

BTW: I wonder if we could remove the duplicated code from
Ruler::Resize(). It calls ImplInitExtraField just few lines above. I am
not 100% sure but it seems that the code in between does not affect
mnVirWidth and the other variables. It does not make sense to call it
twice. It might be enough to do this clean up in master.

Thanks a lot for digging into it.

Best Regards,

More information about the LibreOffice mailing list