[PUSHED 3-6 3-5] fdo#50654: update virtual device width on modifying WB_EXTRAFIELD flag

Ivan Timofeev timofeev.i.s at gmail.com
Mon Aug 13 06:33:44 PDT 2012


Hi Petr,

On 13.08.2012 14:29, Petr Mladek wrote:
> BTW: I wonder if we could remove the duplicated code from
> Ruler::Resize(). It calls ImplInitExtraField just few lines above. I am
> not 100% sure but it seems that the code in between does not affect
> mnVirWidth and the other variables. It does not make sense to call it
> twice. It might be enough to do this clean up in master.

Oh, cool, thanks! :) Done:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fbab3fc351212cd8474159391bc744cee2d7e68

>
> Thanks a lot for digging into it.

Thanks for reviewing my commits!

All the best,
Ivan


More information about the LibreOffice mailing list