[PUSHED][PATCH] fix dead code and fields in Java code

Stephan Bergmann sbergman at redhat.com
Tue Aug 21 01:34:02 PDT 2012


On 08/20/2012 05:37 PM, Caolán McNamara wrote:
> On Fri, 2012-08-17 at 17:15 +0200, Noel Grandin wrote:
>> These patches remove various bits of dead code in the Java files.
>
> With one trivial change built and passed make check for me, pushed now

With Java's reflection mechanisms, it is hard to tell whether a field is 
really unused---even if it is private---, but

> --- a/javaunohelper/com/sun/star/comp/JavaUNOHelperServices.java
> +++ b/javaunohelper/com/sun/star/comp/JavaUNOHelperServices.java
> @@ -29,9 +29,6 @@ import com.sun.star.comp.juhtest.SmoketestCommandEnvironment;
>   */
>  public class JavaUNOHelperServices {
>
> -        static private final String __service_smoketestCommandEnv =
> -        "com.sun.star.deployment.test.SmoketestCommandEnvironment";
> -
>       /**
>       * Gives a factory for creating the service.
>       * This method is called by the <code>JavaLoader</code>

appears to have been of no use indeed (at least, smoketest still works).

Stephan


More information about the LibreOffice mailing list