[PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As

Michael Meeks michael.meeks at suse.com
Tue Aug 21 04:04:12 PDT 2012


On Tue, 2012-08-21 at 10:27 +0200, Stephan Bergmann wrote:
> Yes, using braces is one notable case where I deliberately deviate from 
> existing practice in a given file.

	:-)

> Anyway, even if we agree to disagree here

	I think that's likely ;-)

>  the devilishly deceiving cases I remember all involved if-sans-braces
> which originally covered a single statement plus comment (as above), so
> maybe we can agree that at least in such cases it doesn't harm to add
> redundant braces.

	Totally with you:

	if (pUnobvious)
	{
		// this is something complicated - wake up !
		**((int **)pUnobvious) = 42;
	}

	looks rather sensible to me :-)

	ATB,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list