[Libreoffice-commits] Revert "installer: Use hashref for replace_all_ziplistvariables_in_rtffile"

Michael Meeks michael.meeks at suse.com
Thu Aug 23 02:49:35 PDT 2012

On Thu, 2012-08-23 at 11:03 +0200, Noel Grandin wrote:
> On 2012-08-23 10:43, Michael Meeks wrote:
> > 	When I last looked at some of this horrific line-by-line substitution
> > magic, it turned out to be faster to concatenate all the lines into a
> > single string, run the regexp and split it again rather than do the
> > line-by-line regexping that was there before ;-> horrific but ... still
> > - there are lots of less-moronic ways of doing that replacement ;-)
> Strange. Does perl not have a way to compile and cache regular expressions?

	Sure - I tried that in this instance; it just turned out that running a
regexp over one really big string, was faster than running a compiled

$ wc -l solver/unxlngi6.pro/bin/setup_osl.ins 
103700 solver/unxlngi6.pro/bin/setup_osl.ins

	around that many times ;-)



michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list