[PATCH] Reduced duplicate code (simian) / l10ntools

Ivan Timofeev timofeev.i.s at gmail.com
Sun Feb 5 10:52:52 PST 2012

Hi Christina,

05.02.2012 20:26, Chr. Rossmanith пишет:
> there were three blocks of nearly identical code.

Awful! Thanks for working on this task.

> I've moved them to a method ResData2Output(). Please review.

Looks nice. All of the differences seem to be handled...

 > bWriteNoSlash seems to be always false

Yes. And ByteString sTmp is unused.

> Maybe the spelling of Semikolon should be changed while at it...

Yes, I think.

> and ByteString->rtl::OString...

I think it should be separated... :)

Hmm, interesting, where we can test the "new" code, just in case?


More information about the LibreOffice mailing list