[REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

Michael Meeks michael.meeks at suse.com
Mon Feb 13 03:59:44 PST 2012

On Fri, 2012-02-10 at 18:12 +0100, Jan Holesovsky wrote:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=9951de4a10386a85dc1bfa465304cd0005414b8e

	Workaround looks fine to me :-) I'm amazed that we throw such a hard
exception here, but ...

> Returning a 'I was unable create a cursor' value via throwing runtime
> exception [in SwXFootnote::createTextCursorByRange()] is not really
> efficient ;-) - but I have no idea what I might break by changing that,
> so I just catch the exception in the code that already somehow counts on
> the possibility that the call fails anyway.  This way, the filter fails
> nicely, with our "favorite" 'General Input/Output Error.'

	You have my ack for -3-5 :-) any chance you can push it ?


		Michael (feeling lame).

michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list