[REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

Jan Holesovsky kendy at suse.cz
Mon Feb 13 04:15:16 PST 2012

Hi Michael,

Michael Meeks píše v Po 13. 02. 2012 v 11:59 +0000:

> > Returning a 'I was unable create a cursor' value via throwing runtime
> > exception [in SwXFootnote::createTextCursorByRange()] is not really
> > efficient ;-) - but I have no idea what I might break by changing that,
> > so I just catch the exception in the code that already somehow counts on
> > the possibility that the call fails anyway.  This way, the filter fails
> > nicely, with our "favorite" 'General Input/Output Error.'
> 	You have my ack for -3-5 :-) any chance you can push it ?

Done, thank you for the review!


More information about the LibreOffice mailing list