[REVIEW][PUSHED 3-5][PUSHED 3-4] fdo#41712 SwFlowFrm::pPrecede regression

Cedric Bosdonnat cbosdonnat at suse.com
Mon Feb 13 09:39:28 PST 2012


On Mon, 2012-02-13 at 15:02 +0100, Cedric Bosdonnat wrote:
> Hi Michael,
> 
> On Mon, 2012-02-13 at 13:01 +0100, Michael Stahl wrote:
> > apparently a SwFlowFrm::pPrecede was introduced, turning the SwFlowFrm
> > list from a singly linked list to a doubly linked list, without much
> > thought given to the additional invariants that need to be maintained;
> > these patches should fix that up and should go into libreoffice-3-4 and
> > libreoffice-3-5:
> 
> Sounds like my initial patch wasn't complete. Thanks for spotting the
> problem and fixing it.
> 
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c0970c2be45ea62d86e24271065311aaa92c0186
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=657c500e2e9e9ad2e38e9da278b20fb82c109001
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9f6e5323eaa3078f0a3a00a37cee169ba7dedbc
> 
> I just pushed these 3 commits to -3-5. (Still to be done for 3-4... due
> to lazyness).

Found some courage to do it... loads of changes in the code in between,
but nothing really serious. These commits are now in 3-4 branch.

--
Cedric



More information about the LibreOffice mailing list