[PATCH] Turn on strictures for some installer Perl modules

Tim Retout tim at retout.co.uk
Tue Feb 14 15:02:32 PST 2012


I'd like to try to clean up some of the code in the solenv Perl
modules - as a first task, I want to turn on 'use strict', which I'd
consider a bare minimum for maintainable Perl.  Longer-term,
Perl::Critic flags up lots of nice stuff, and then there's performance
and so on.

My first few attempts at this have ended up ballooning into large
tasks - for instance, there seem to be lots of unused subroutines in
the installer code, which could safely be removed.  But I then end up
not sending in any patches, and have no idea if I'm going way beyond
what's acceptable. :)

So here's a first small patch that should be quite safe.

One thing I'd like to check: is the best way to test make_installer.pl to run:

  source config_host.mk
  solenv/bin/ooinstall /tmp/foo

(I get a few errors when sourcing config_host.mk.)

I've added my name to
https://wiki.documentfoundation.org/Development/Developers with a link
to my previous license statement on the mailing list.

Kind regards,

Tim Retout <tim at retout.co.uk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Turn-on-strictures-for-some-installer-Perl-modules.patch
Type: text/x-patch
Size: 2286 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120214/1ed479da/attachment.bin>

More information about the LibreOffice mailing list