[PATCH] Remove unused code from gtkframe
caolanm at redhat.com
Thu Feb 16 03:10:45 PST 2012
On Wed, 2012-02-15 at 22:55 +0100, Michael Stahl wrote:
> On 15/02/12 21:31, Kate Goss wrote:
> > Hi Michael, Caolan,
> > How accurate/ up to date is unusedcode.easy? Is there a way to make sure
> > the methods I'm removing are genuinely unused?
Its generally up to date, but it always requires at least some casual
manual inspection to see if the code is used in some specific
configuration, e.g. sticking the name into opengrok.libreoffice.org to
see if there are some uses hidden behind #ifdef WNT or something of that
nature. If it was a completely automatizable operation we could just
script up something to remove them all in one go :-(
I've now moved those two unused-in-normal-configuration methods behind
GTK3 conditionals where the rest of the similar code lived already.
> the problem is that unusedcode.easy is generated from a single
> configuration of LO. because there is a huge number of potential
> configurations, there may be some false positives
I don't consider them "false positives" btw. e.g. if there was, say,
300MB of binary in our Linux install which was only called on some
Windows specific code-path then I imagine we'd like to only
conditionally include it on the appropriate platform.
More information about the LibreOffice