input for fdo#45779 from a basegfx knowledgeable person needed

Thorsten Behrens thb at documentfoundation.org
Wed Feb 15 02:03:24 PST 2012


Pierre-André Jacquod wrote:
> B2DTuple(const B2DTuple& rTup)
> ... 
> Here you dereference the null pointer, which crash.
> 
> Ok, the basic attitude would be to let B2DTuple be Null-pointer
> consistent: (checking that rTup is not NULL), but is it really a
> good idea?
> 
Hi Pierre-André,

no, what's passed is a reference, which by definition is always
de-referencable - so the bug is in the calling code.

> Or should I look higher in the hierarchy, saying that a NULL point
> in a B2DPolygon has nothing to do and disallow it ?
> 
Yes, the calling code somehow accesses invalid elements. Let me have
a look.

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120215/00b924a8/attachment.pgp>


More information about the LibreOffice mailing list