[PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

Mariusz Dykierek mariuszdykierek at gmail.com
Sat Feb 18 06:08:30 PST 2012


On 2012-02-18 14:41, Ivan Timofeev wrote:
> On 18.02.2012 17:29, Mariusz Dykierek wrote:
>> I have a 'replacement' patch that actually replaces most of if...else if...else chains with
>> switches.
>
> Great!
>
>> They are more legible and seem natural when choosing branches depending on the same variable.
>
> On the other hand, the evaluated expression is not visible at the first-look... A lot of
> people - a lot of opinions :)
>
>> Question I have, is how do I submit the patch:
>>   - as a reply to this thread, or
>>   - a new patch in a new thread?
>
> I think, if a patch extends or replaces a current one - submit as a reply, otherwise - start a
> new thread.
>
> Cheers,
> Ivan
>
Attached is the "new" patch that replaces and extends the previous one in this thread.
Regards,
Mariusz


More information about the LibreOffice mailing list