[PUSHED][3-5][REVIEW][3-5-1] fdo#46340 add more insanity to SdrGrafObj::getInputStream so it doesn't crash as much

Michael Meeks michael.meeks at suse.com
Wed Feb 29 22:50:18 PST 2012

On Wed, 2012-02-29 at 22:56 +0100, Michael Stahl wrote:
> propose the following for libreoffice-3-5, which fixes
> a crash regression in 3.5 when saving pictures.
> if you are thoroughly confused by now, then you have reached an accurate
> understanding of the situation.

	So - the patch looks like a reasonable workaround given the horror
implementations of the UNO stream / storage interfaces. Wow - we really
need some hero to do a complete re-work of the lifecycle, and path
access semantics of all those implementations [ with some decent unit
tests to boot ;-].

> so this patch just restores the aspects of the previous mis-design that
> accidentally prevent the crash.

	Pushed to libreoffice-3-5 anyhow; two more ack's for -3-5-1.

	Thanks !


michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list