[Libreoffice] [REVIEW] Re: minor problems with format -> page -> organizer

[Lior Kaplan]

On Sat, Jan 7, 2012 at 7:39 PM, Ivan Timofeev <timofeev.i.s at gmail.com>wrote:

> 06.01.2012 20:57, Lior Kaplan пишет:

    The strings are coming from svx/source/items/svxitems.src
>>    (RID_SVXITEMS_PAGE_LAND_FALSE and RID_SVXITEMS_PAGE_USAGE_LEFT), and
>>    the only reference for them I found is svx/source/items/pageitem.cxx
>>
>>    I compared it to the code of other items in the page, and didn't
>>    find any space addition the other strings... any idea why in this
>>    case there's a missing space?
>>
>
> Bug? The author forgot to add the delimiter?
>
>            if ( bLandscape )
>                rText += SVX_RESSTR(RID_SVXITEMS_PAGE_**LAND_TRUE);
>            else
>                rText += SVX_RESSTR(RID_SVXITEMS_PAGE_**LAND_FALSE);
> -           rText += GetUsageText( eUse );
> +           String aUsageText = GetUsageText( eUse );
> +           if (aUsageText.Len())
> +           {
> +               rText += cpDelim;
> +               rText += aUsageText;
> +           }
>            return SFX_ITEM_PRESENTATION_**NAMELESS;
>
>        }
>

Cool (:

This fix is also relevant a few lines bellow, adding a patch to include
them both.

Also, including [REVIEW] in the subject.

Kaplan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120107/3e521225/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pageitem.cxx.patch
Type: text/x-diff
Size: 1305 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120107/3e521225/attachment.patch>