[Libreoffice] [REVIEW 3-5] remove duplicated icons from soffice.bin/soffice.exe (fdo#37740)
timar74 at gmail.com
Thu Jan 19 04:01:46 PST 2012
2012/1/19 Michael Meeks <michael.meeks at suse.com>:
> Hi Andras,
> On Wed, 2012-01-18 at 22:02 +0100, Andras Timar wrote:
>> Under Windows soffice.exe and soffice.bin contained 40 icons each.
> Right - I had always assumed that these were used for file associations
> and rendering in the windows explorer etc.
>> Many icons were duplicated.
> At various different sizes ? or duplicated beyond that ?
Duplicated beyond that. Windows .ico files contain icon sets, each
file contains 16x16, 32x32, 48x48, 128x128, and 256x256 icons. But
many identical .ico files were embedded into the resource with
different names (for historical reasons). Almost all of them were
referenced from the code.
Another level of duplication was that soffice.exe and soffice.bin both
contained the same 40 icons. soffice.exe contained the icons for
Windows Explorer, soffice.bin contained the icons for application
windows' titlebar and Alt-Tab. Now Windows Explorer takes the icons
from soffice.bin, too.
> Are we confident that this will not alter the look of .ods / .odt etc.
> in windows explorer at different zoom levels ? Are we confident that the
> Alt-Tab application icon images are un-affected [ really we should get
> those from images.zip IMHO but ... ].
Zoom levels are not affected. And yes, I read your comment in the bug
about images.zip. But I have no idea how to create an icon handle from
an image runtime, that Windows API call expects.
More information about the LibreOffice