[Libreoffice] LibreOffice Code Cleanup Patch

Muthu Subramanian K sumuthu at suse.com
Thu Jan 26 20:55:22 PST 2012


@Alex: Forgot to mention one more thing: We follow (normally) space
after '(' and before ')' if there are parameters. Sometimes, we would be
tempted to remove the space in cases like foo( param1, param2 ); as well
;) ( I am always tempted in such cases :P )

On 01/27/2012 10:19 AM, Muthu Subramanian K wrote:
> Hello Alexander,
> 
> Its nice to see those patches. But, it will be nice to see/use the
> tools/scripts directly? Especially if they can be hooked to git (like
> the current white space/tabs removal ones)?
> 
> @lubos: Alexander is good with scripts, so as a starter he wanted to do
> something like
> "http://cgit.freedesktop.org/libreoffice/core/commit/?id=59cefd339d0c3fcde5b614d7f142a957397672d9"
> . So, yes, I had asked him to give it a shot. I guess, the patch is good
> as well?
> 
> Thanks!
> Muthu Subramanian
> 
> On 01/26/2012 10:03 PM, Alexander Bergmann wrote:
>>  Hi Muthu,
>>
>> as I announced yesterday, I started a search & replace task. But - as
>> life goes - this is not wanted? I thought, you encouraged me to do this
>> sort of thing... See:
>> http://lists.freedesktop.org/archives/libreoffice/2012-January/024616.html
>> and
>> http://lists.freedesktop.org/archives/libreoffice/2012-January/024624.html
>>
>> The patch should replace SAL_THROW( () ) by SAL_THROW(()) and THROWS( ()
>> ) by THROWS(()). Actually at the moment both versions of SAL_THROW and
>> THROWS are used in the LibreOffice code base.
>>
>> Best regards,
>> Alexander
>>
> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 



More information about the LibreOffice mailing list