[Libreoffice] Duplicate branches for if and else in store/source/storlckb.cxx

[julien2412]

Hello,

Cppchecks reports this :
core/store/source/storlckb.cxx
74	duplicateBranch	style	Found duplicate branches for if and else.

Here are the lines : 
     67 OStoreLockBytes::~OStoreLockBytes (void)
     68 {
     69     if (m_xManager.is())
     70     {
     71         if (m_xNode.is())
     72         {
     73             OStorePageDescriptor aDescr (m_xNode->m_aDescr);
     74             if (m_bWriteable)
     75                 m_xManager->releasePage (aDescr);
     76             else
     77                 m_xManager->releasePage (aDescr);
     78         }
     79     }
     80 }

It's from commit 7c704c78d3c652504c064b4ac7af55a2c1ee49bb 

Could we just remove the if or must something be added ?

Julien.

--
View this message in context: http://nabble.documentfoundation.org/Duplicate-branches-for-if-and-else-in-store-source-storlckb-cxx-tp3701331p3701331.html
Sent from the Dev mailing list archive at Nabble.com.