[Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

Tommy barta at quipo.it
Tue Jan 31 21:12:17 PST 2012

On Mon, 30 Jan 2012 22:35:46 +0100, Kohei Yoshida <kohei.yoshida at suse.com>  

> Hi,
> I'd like
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4
> cherry-picked to the 3-5 branch.  It is probably too late for change
> like this to be in the 3-5-0 branch so I won't even try.
> ---- SNIP ----
> The problem is, this counter is
> unsigned 16-bit integer, and as soon as it goes above 65535 it rolls
> back to zero, and eventually the token instance gets deleted
> prematurely.

this issue sounds similar to  
Bug 87672 - autocorrect limit. acor.dat with entry 65535: Loop and/or loss  
of acor data

> As an aside, although it's not necessary for this fix, on master we
> should probably use unsigned 32-bit integer to store reference counter
> for this just to future-proof ourselves.  16-bit integer seems a bit too
> small for this purpose.
> Regards,
> Kohei

I don't know if tha autocorrect is your area,
anyway do you think that is technically possible to replace in the future  
16-bit .xml autocorrect files with 32-bit files in order to increase the  
of autocorrect entries?

More information about the LibreOffice mailing list