[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Ivan Timofeev timofeev.i.s at gmail.com
Tue Jan 31 07:24:02 PST 2012

31.01.2012 18:22, Noel Power пишет:
> On 30/01/12 13:54, Noel Grandin wrote:
>> Attached patch converts SdCustomShow to use std::vector.
> I hate these remove list etc. type patches as they tend to be tricky and
> time consuming to look at ;-) . The patch looked ok for me, hopefully if
> I missed something ( 'cause these really are tricky ) then someone else
> will spot it.

std::remove doesn't remove elements from the vector. It just moves the 
elements to the front. So we have to 'vector::erase' garbage when 
replacing RemovePage by std::remove. Am I right?


More information about the LibreOffice mailing list