[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Noel Grandin noel at peralex.com
Tue Jan 31 07:42:02 PST 2012

So I should be calling
    maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );

On 2012-01-31 17:24, Ivan Timofeev wrote:
> 31.01.2012 18:22, Noel Power пишет:
>> On 30/01/12 13:54, Noel Grandin wrote:
>>> Attached patch converts SdCustomShow to use std::vector.
>> I hate these remove list etc. type patches as they tend to be tricky and
>> time consuming to look at ;-) . The patch looked ok for me, hopefully if
>> I missed something ( 'cause these really are tricky ) then someone else
>> will spot it.
> std::remove doesn't remove elements from the vector. It just moves the 
> elements to the front. So we have to 'vector::erase' garbage when 
> replacing RemovePage by std::remove. Am I right?
> Ivan

Disclaimer: http://www.peralex.com/disclaimer.html

More information about the LibreOffice mailing list