gerrit lame / non-reviews spammage

[Michael Meeks]

Hi Bjoern,

	Thanks for fixing the Subjects - that is extremely helpful :-)

On Tue, 2012-07-10 at 11:59 +0200, Bjoern Michaelsen wrote:
> The tricky question is: what is a 'substantive review'? Some Ideas:

	Hard to see of course; then again - if we could substantially shrink
the content of the mail; perhaps it'd be easier to skim through. It
seems (like most of the gerrit tools) that verbosity is thought to be an
advantage ;-)

[snip]
Subject: 	Change in core[master]: add/remove blank lines and braces (in sw/source/core/crsr/)
Date: 	Mon, 9 Jul 2012 12:42:45 +0000 (07/09/2012 01:42:45 PM)

>From David Ostrovsky <David.Ostrovsky at gmx.de>:

David Ostrovsky has posted comments on this change.

Change subject: add/remove blank lines and braces (in sw/source/core/crsr/)
......................................................................
[/snip]

	So - to this point we've duplicated David's name, added a lot of text
to scan, duplicated the subject line and added a ........... :-)

[snip]
Patch Set 1:

I described here:
http://lists.freedesktop.org/archives/libreoffice/2012-July/034664.html
how to submit the next patchset.
[/snip]

	and then an ignoreable footer I guess.

[snip]
--
To view, visit https://gerrit.libreoffice.org/272
To unsubscribe, visit https://gerrit.libreoffice.org/settings
[/snip]

	With only web links in it :-)

	I'd love to see instead changes '*'d: (can we spoof the sender ?):

[snip]
From: David Ostrovsky <David.Ostrovsky at gmx.de>:
Subject: *Comment* **: add/remove blank lines and braces (in sw/source/core/crsr/)
Date: 	Mon, 9 Jul 2012 12:42:45 +0000 (07/09/2012 01:42:45 PM)

I described here:
http://lists.freedesktop.org/archives/libreoffice/2012-July/034664.html
how to submit the next patchset.

-- 
To view this patch use: logerrit foo baa show afdb273a2843..
To visit the web-site see: https://gerrit.libreoffice.org/272
[/snip]

	Which is much more skim-able; of course, people may reply to such
mails ;-) and discuss on the mailing list - presumably that causes some
level of complexity but ...

> Should be done now. I removed the "Change in core[master]" boilerplate and
> added '[PATCH]' and '[PUSHED]' as appropriate. If we want to have it more fancy
> we could do virtually everything with

	That's lovely :-)

> but the hard part is coming up with a sensible definition what we (as a
> community of devs) want. The last time we discussed that it ended in 'send
> everything to the list', which proved suboptimal in the end. So some more
> frontup work needed there.

	Yep - on the other hand, it's nice to see it iterating towards
something much better - clearly glueing together the mail & web
work-flows was never going to be perfectly easy :-)

	Thanks !

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot