[REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

Eike Rathke erack at redhat.com
Fri Jul 13 12:48:05 PDT 2012

Hi Markus,

On Friday, 2012-07-13 20:39:07 +0200, Markus Mohrhard wrote:

> In case of swapping we don't need all the special cases of ScAttrArray
> for finding the right place and inserting removing from the doc pool,
> we can just exchange the two pointers which is faster and does not
> require manual manipulation of ref counts.

But, exchanging pointers works correctly only if both patterns cover
exactly one row each, not if one or both apply to more rows. So, while
inserting/removing from docpool may not be needed, splitting or merging
the area still is.

Or what do I miss? I didn't try the patch.


LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120713/b579f3f7/attachment.pgp>

More information about the LibreOffice mailing list