[REVIEW 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history

Caolán McNamara caolanm at redhat.com
Sun Jul 15 00:43:38 PDT 2012

On Sun, 2012-07-15 at 08:32 +0900, Takeshi Abe wrote:
> Hi,
> Having reproduced fdo#52013 on master, I would like to ask for a favor of reviewing
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b689371cc344f14af783f87c7fe37f5350c10ab
> for 3.6.

Seems to me that the original conversion of
9c0ca924446933431d736ee0dd37e6852b4947dc should have used vector::insert
rather than std::copy ?, i.e. like the attached

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sw.rolbck.insert.patch
Type: text/x-patch
Size: 719 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120715/ec1c92d4/attachment.bin>

More information about the LibreOffice mailing list