[REVIEW 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history

Takeshi Abe tabe at fixedpoint.jp
Sun Jul 15 03:00:56 PDT 2012

Hi Caolán,

Thank you for your review!

On Sun, 15 Jul 2012 08:43:38 +0100, Caolán McNamara <caolanm at redhat.com> wrote:
> On Sun, 2012-07-15 at 08:32 +0900, Takeshi Abe wrote:
>> Having reproduced fdo#52013 on master, I would like to ask for a favor of reviewing
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b689371cc344f14af783f87c7fe37f5350c10ab
>> for 3.6.
> Seems to me that the original conversion of
> 9c0ca924446933431d736ee0dd37e6852b4947dc should have used vector::insert
> rather than std::copy ?, i.e. like the attached
Exactly, I stand corrected.
Please push it to master, and do we need another ack for the 3.6 branch?

-- Takeshi Abe

> C.

More information about the LibreOffice mailing list