[GSoC 2012][Collaboration] status, ideas
matus.kukan at gmail.com
Tue Jul 17 03:24:47 PDT 2012
On 16 July 2012 15:16, Eike Rathke <erack at redhat.com> wrote:
> Hi Matúš,
> On Saturday, 2012-07-14 19:49:29 +0200, Matúš Kukan wrote:
>> What's wrong:
>> - TeleManager is never destroyed.
>> Because I don't know where.
> I think ScDocFuncSend and/or ScDocFuncRecv could hold a pointer they
> obtained from TubeContacts and call TeleManager::unref() when destroyed.
> Make sure TubeContacts passes the pointer by calling TeleManager::get()
> to increment the reference count and unrefs any instance it obtained via
> get() itself.
I think that we may want TeleManager to live when there is no document yet.
Definitely before some document is shared, so before ScDocFuncSend.
The code in TubeContacts is wrong btw.
Imagine that we install .service .client files and somebody wants to
share a file with us for collaboration.
Channel dispatcher runs ./soffice --accept-tube and some code in
desktop/ starts TeleManager which receives the file, incoming channel
and sets the collaboration.
If we want this.
More information about the LibreOffice