gbuild deps: removed header

David Tardon dtardon at redhat.com
Sun Jul 22 23:14:09 PDT 2012


Hi,

On Sun, Jul 22, 2012 at 09:01:45PM +0200, Matúš Kukan wrote:
> Hi all,
> 
> Should gbuild dependencies survive removed header ?

Yes, ideally :-)

> 
> Something like:
> touch solver/*/inc/foo.h
> +#include <foo.h>
> e.g. in salhelper/source/condition.cxx
> make gb_FULLDEPS=T salhelper
> Now workdir/*/Dep/LinkTarget/Library/*salhelper*.d should contain foo.h
> So:
> rm solver/*/inc/foo.h
> -#include <foo.h>
> in salhelper/source/condition.cxx
> and make gb_FULLDEPS=T salhelper fails for me. Is it expected ?
> I thought it could work.
> 
> But what works is if we use
> /home/matus/git/libo/solver/unxlngx6.pro/inc/foo.h:
>     @true
> 
> instead of just
> /home/matus/git/libo/solver/unxlngx6.pro/inc/foo.h:
> 
> Do we want to hack contac-deps and add @true there ?
> Is there another option or is this just wrong ?

IMHO this will cause problems for headers in solver, because a specific
rule for a file overrides a pattern rule, which means that delivery of
changed headers will stop working.

> Also, I am wondering, has this ever been working before ?

I do not think it has. (Note that this is a problem with idl and hrc
files too.)

D.


More information about the LibreOffice mailing list