[PATCH] fdo#42492: fixing Basic HEX command

Noel Power nopower at suse.com
Tue Jul 31 12:37:35 PDT 2012


On 31/07/12 18:16, János Uray wrote:
> Why did you extend the comment: "// converting value to unsigned /and 
> limit to 2 or 4 byte representation/"? GetInteger() and GetLong() 
> return sal_Int16 and sal_Int32, respectively, so the static_casts only 
> convert them to unsigned.
it's just the way I think about it :-) the basic language numerical 
representation is a 2 byte or 4byte format, that with the fact the value 
in basic types is one big huge union :-) If the comment disturbs you or 
makes things more unclear then feel free to get rid of it ( to be honest 
I don't even recall typing it :-) )

Noel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120731/af1dd8d1/attachment.html>


More information about the LibreOffice mailing list