[PATCH] fdo#42492: fixing Basic HEX command

[János Uray]

I also like to avoid C-style string handling, but valueOf() doesn't support
unsigned integers (it should support all C++ integer types), and converting
to sal_Int64 didn't come into my mind.
Why did you extend the comment: "// converting value to unsigned *and limit
to 2 or 4 byte representation*"? GetInteger() and GetLong() return
sal_Int16 and sal_Int32, respectively, so the static_casts only convert
them to unsigned.

Uray M. János

On Tue, Jul 31, 2012 at 3:38 PM, Noel Power <nopower at suse.com> wrote:

> Ok, pushed now and also with a further tweak to avoid sprintf and the
> hardcoded buffersize ( 'cause 17 is too big anyway )
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=02a7dfb729799f9e1437a718951566640d0fde02
> l
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120731/f2e33e35/attachment.html>