Incorrect OSL_ENSURE -> SAL_WARN_IF conversions (Re: [Libreoffice-commits] .: sw/source)

Miklos Vajna vmiklos at suse.cz
Thu Jun 7 00:24:21 PDT 2012


On Wed, Jun 06, 2012 at 06:28:48PM +0200, Lubos Lunak <l.lunak at suse.cz> wrote:
> 
>  Hello,
> 
>  please note that when convering from the obsolete OSL_ENSURE or similar 
> macros to SAL_WARN_IF, the condition needs to be inverted. OSL_ENSURE is a 
> (broken) assert-like macro and so it requires the condition to be true or it 
> warns. SAL_WARN_IF, as the name says, requires the condition to be false and 
> warns on true.

Hi Lubos,

Hah, thanks for pointing that out, didn't notice the difference.

Miklos


More information about the LibreOffice mailing list