[PUSHED-3-5]Re: [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

Lubos Lunak l.lunak at suse.cz
Tue Jun 12 05:41:14 PDT 2012


On Tuesday 12 of June 2012, Michael Stahl wrote:
> i've fixed the other ones, please review and push to libreoffice-3-5:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd18b8e313b792f5fc4
>2edb3314a95d202406899

 Pushed.

On Tuesday 12 of June 2012, Michael Stahl wrote:
> On 12.06.2012 14:12, Tor Lillqvist wrote:
> >> No, growing a vector (which push_back can do) invalidates all references
> >> into the vector.
> >
> > Would building with --enable-dbgutil on Linux (thus defining
> > _GLIBCXX_DEBUG) had caught this problem?
>
> no, because there's no iterator involved: back() returns a reference to
> the value_type.

 It technically could, by checking in every method that can invalidate 
references that the passed argument is not such a reference (to one of the 
elements).

-- 
 Lubos Lunak
 l.lunak at suse.cz


More information about the LibreOffice mailing list