[GSOC] ODS Row height import

[Olivier Hallot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Em 26-06-2012 06:35, Eike Rathke escreveu:
> Hi,
> 
> On Tuesday, 2012-06-26 03:46:47 +0200, Markus Mohrhard wrote:
> 
>>> ScXMLImport::endDocument() did use ScMyTables::UpdateRowHeights() which used
>>> ScTable::SetOptimalHeightOnly() to set the row heights for the visible sheet
>>> and any sheets with tabs.  I removed the call to this method, and I removed
>>> the method itself since nothing else was using it.
>>>
>>> Turns out that the row height was already being imported using UNO.
>>>  ScXMLTableRowContext::EndElement() uses
>>> XMLTableStyleContext::FillPropertySet() which uses
>>> ScDocument::SetRowHeightOnly() to set the row height to the imported row
>>> height values.  This remains.
> 
> There's a big difference between ScTable::SetRowHeightOnly() and
> ScTable::SetOptimalHeightOnly(), the latter as a side effect also
> recalculates formula results if the cell is marked dirty. Just keept
> that in mind when removing the call.. if a formula result stored in the
> file differs from the actual result (i.e. because some generator updated
> only the result or only the formula) row height may be different when
> recalculated.
> 
> 
>>> Do you think there is something I am missing here?  For example, will there
>>> ever be a case where row height is not specified, requiring us to calculate
>>> the row height?
> 
> That may be possible, the style:row-height attribute is optional in ODF,
> so while we write it out even when style:use-optimal-row-height is set,
> other implementations may not.
> 
>> I'm not sure if we need to recalculate the row height in case of
>> style:use-optimal-row-height
>>  but that is something we can figure out later. Except for this case I
>> currently see no reason why we would need to calculate row height but
>> Kohei or Eike may have an idea.
> 
> I'm Cc'ing also Noel here, he lately tuned row heights for Excel
> import/export and might have some insights to share.
> 
>   Eike
> 
> 
> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

Sorry if I distract you from the issue but this may be correlated:

http://www.libreoffice.org/bugzilla/show_bug.cgi?id=40645

FORMATTING: Calc looses row height on reopening the file

Regards
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Fundação responsável civilmente, de acordo com o direito civil
Detalhes Legais: http://www.documentfoundation.org/imprint
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJP6YRUAAoJEJp3R7nH3vLxon0H/2KKVByIrXCpzNuozKtsU+J8
AobO/cD4BTjTGA+TwwBwpHfRSrtsQfqqqBZssZi9f+gOTvA5AgwoA9SpPbmYgTRQ
1lKt1fIYXDj3SvcgOEa2ldk0BXlEy/PaCkQMUiAATjQ02NFqm9iPadjyhtbZh7Qz
u3glRzHDacA1uIR7luYpQUCQ82MRbkaIBI3NF7809Atmtlc2Av4bhGi+OpugtZgu
ZaK4CfYSPVmS2vLJzU0OgepRxokpeLQ1YleP13bqWzEY8yPdG0fcKeWsrduMxD/1
gfzudj1Kre6cOjnIy5saTHiPp7Jf80j8nqKdAWrIYe2OfGADrSObpIm2aVmGG3o=
=MIno
-----END PGP SIGNATURE-----