[REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms "Data navigator" dialog

Michael Stahl mstahl at redhat.com
Thu Mar 1 04:52:39 PST 2012


On 01/03/12 13:20, Noel Power wrote:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804
> 
> should fix the problem, it seems that commit 
> f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( 
> it seems from the comment to silence some cppcheck error ) but that 
> delete doesn't imo make any sense.

indeed that delete looks completely bogus, pushed to libreoffice-3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=369aea7f7402e9dc98e9347ae58999dad2d21652

2 more needed for -3-5-1

since buggy code seems to be there as well, also pushed to libreoffice-3-4:

http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4&id=0aaa35c6d3b07a273af6a1be2d26add4a9d537cd



More information about the LibreOffice mailing list