[PUSHED:3-4,3-5][REVIEW:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog

Petr Mladek pmladek at suse.cz
Thu Mar 1 05:31:47 PST 2012


Michael Stahl píše v Čt 01. 03. 2012 v 13:52 +0100:
> On 01/03/12 13:20, Noel Power wrote:
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804
> > 
> > should fix the problem, it seems that commit 
> > f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( 
> > it seems from the comment to silence some cppcheck error ) but that 
> > delete doesn't imo make any sense.
> 
> indeed that delete looks completely bogus, pushed to libreoffice-3-5:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=369aea7f7402e9dc98e9347ae58999dad2d21652
> 
> 2 more needed for -3-5-1

Looks fine to me. One more review needed for -3-5-1.


Best Regards,
Petr



More information about the LibreOffice mailing list