[REVIEW 3-5]: don't loose data on disk failure (fsync) fdo#40607

Stephan Bergmann sbergman at redhat.com
Mon Mar 12 01:43:40 PDT 2012

On 03/09/2012 06:17 PM, Michael Meeks wrote:
> 	I'd love some thoughts on this. Of course, finding the right place to
> put the osl_syncFile took a fair while, but then to discover that the
> dp_manager was bootstrapping all that UCB-ness just to create and delete
> a file, twice on startup each time ... we certainly can't be doing an
> fsync on startup on old file-systems it'd be a killer, and just look
> like an ultra-slow start.
> 	Anyhow - hopefully this will save someone some theoretical data, or at
> least give a new idea of where to look for data-loss :-) I also tend to
> loathe these 'vnd.expand' URLs. I wish we had a simple low-level API for
> them we could use everywhere, that had the more complex (?)
> configmgr-ness hooked into it at run-time. Anyhow - hopefully this
> didn't break some ultra-complicated expansion use-case.
> 	Thoughts appreciated,

As discussed on IRC, the patch breaks smoketest/adding extensions (and 
my attempt at a quick fix was futile).


More information about the LibreOffice mailing list