[REVIEW 3-5]: don't loose data on disk failure (fsync) fdo#40607

Michael Meeks michael.meeks at suse.com
Mon Mar 12 08:06:12 PDT 2012

On Mon, 2012-03-12 at 09:43 +0100, Stephan Bergmann wrote:
> As discussed on IRC, the patch breaks smoketest/adding extensions (and 
> my attempt at a quick fix was futile).

	Ah yes - it turns out that:

-                ::ucbhelper::Content ucbStamp( stampURL, xCmdEnv );
-                ::rtl::OString stamp(
-                Reference<io::XInputStream> xData(
-                    ::xmlscript::createInputStream(
-                        ::rtl::ByteSequence(
-                            reinterpret_cast<sal_Int8 const *>(stamp.getStr()),
-                            stamp.getLength() ) ) );

	Creates a parent directory if it is not present, something not entirely
obvious when reading it ;-) Fixed on master.

	I attach a unified patch:
fdo#40607 - osl_syncFile having written, and avoid doing that on start



michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fdo-40607-syncfile.patch
Type: text/x-patch
Size: 6506 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120312/1b684f8e/attachment.bin>

More information about the LibreOffice mailing list