Cppcheck reports "Same expression on both sides of '=='" on dpitemdata.cxx

[julien2412]

Hello,

Just to make notice that Cppcheck reports "Same expression on both sides of
'=='" on sc/source/core/data/dpitemdata.cxx, line 217. Here are the lines :

    199 bool ScDPItemData::IsCaseInsEqual(const ScDPItemData& r) const
    200 {
    201     if (meType != r.meType)
    202         return false;
    203 
    204     switch (meType)
    205     {
    206         case Value:
    207         case RangeStart:
    208             return rtl::math::approxEqual(mfValue, r.mfValue);
    209         case GroupValue:
    210             return maGroupValue.mnGroupType ==
r.maGroupValue.mnGroupType &&
    211                 maGroupValue.mnValue == r.maGroupValue.mnValue;
    212         default:
    213             ;
    214     }
    215 
    216     if (mbStringInterned && r.mbStringInterned)
    217         return mpString == mpString;  <---- HERE
    218 
    219     return ScGlobal::GetpTransliteration()->isEqual(GetString(),
r.GetString());
    220 }

It's the commit f81d15c3bab32938b5b475e16ae2a746a7a32ea9 (17/03/2012).

Julien.

--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-on-dpitemdata-cxx-tp3836145p3836145.html
Sent from the Dev mailing list archive at Nabble.com.